weiqingy commented on issue #1045: URL: https://github.com/apache/flink-agents/issues/1045#issuecomment-5467308902
#1043 merged with an approving review that raised the same trade-off, so recording it here as the bar for the second half of this issue: > pinning `bash` through `PATH` also makes `install.sh` run under the newer Bash used by Bats, so the regular suite no longer exercises the stock macOS Bash 3.2 environment that the installer supports ... we should ensure the follow-up restores separate Bash 3.2 coverage for the script under test. https://github.com/apache/flink-agents/pull/1043#pullrequestreview-5028261141 That is item 2 above. The PR will invoke the scripts under test through an explicit interpreter, so the harness floor (4.1+) and the subject's environment stay independent, and `install.sh` is exercised on 3.2 again. Traps first, per the order above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
