pranavshuklaa commented on issue #1072: URL: https://github.com/apache/flink-agents/issues/1072#issuecomment-5469381599
Hi @weiqingy I would like to work on this if it is open. My initial read is to bound both download_to_tempfile and extract_zip_safely in _materialize.py reject an over-cap Content-Length up front, independently track bytes as they stream in so a missing or incorrect header can't bypass the check, and enforce per-entry size, cumulative size, and entry-count limits while extracting rather than after. I could then mirror the same logic in skillmaterializer.java on the java side. I want to confirm the direction with you first, particularly around the limits and whether you’d prefer the Java and Python changes together or separately. Also Do you have specific limits in mind for the download/extraction caps? Happy to take this up and work on the implementation once I have your direction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
