slachiewicz commented on code in PR #289:
URL:
https://github.com/apache/flink-connector-kafka/pull/289#discussion_r3890591711
##########
flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/dynamic/source/enumerator/DynamicKafkaSourceEnumerator.java:
##########
@@ -555,10 +551,10 @@ private Set<KafkaStream>
handleFetchSubscribedStreamsError(
}
}
- /** NOTE: Must run on coordinator thread. */
+ /** NOTE: Must run on gate thread. */
Review Comment:
Good catch — the rename overreached into the `coordinator thread` references
from `runInCoordinatorThread`. All five spots restored in 3eaf13fc (the two
javadoc notes, the `coordinatorFailure` catch variable, and the log message +
argument); everything else named `gate` is the `ReaderRecoveryGate` itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
