haruki-830 commented on PR #4512: URL: https://github.com/apache/flink-cdc/pull/4512#issuecomment-5473171015
The 2 PRs apply to different validation paths. #4505 makes Calcite validation follow the existing UDF-first Janino behavior, while this PR adds AI model reference and capability validation that runs earlier. Without this check, a same-named UDF such as `AI_SENTIMENT(id)` would be treated as the built-in AI function and rejected before #4505’s resolution logic is reached. So I think it is necessary to keep this handling. > One minor question: why do we need to modify JaninoParser after #4505? Shouldn't the UDF-precedence logic have been implemented there? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
