manner commented on code in PR #29050:
URL: https://github.com/apache/flink/pull/29050#discussion_r3901933811
##########
flink-core/src/main/java/org/apache/flink/types/variant/BinaryVariantUtil.java:
##########
@@ -415,8 +445,11 @@ public static long getLong(byte[] value, int pos) {
case DATE:
return readLong(value, pos + 1, 4);
case INT8:
+ case TIME:
case TIMESTAMP_LTZ:
case TIMESTAMP:
+ case TIMESTAMP_LTZ_NS:
+ case TIMESTAMP_NS:
Review Comment:
You're right, this should be properly documented. I think documentation will
mostly happen in this ticket:
https://issues.apache.org/jira/browse/FLINK-40494
When converting goes wrong it will now throw a `VariantTypeException` with a
helpful error message:
https://github.com/apache/flink/pull/29050/changes#diff-2a1f60d1bf5ca4585c1c2d08c51866702d17d70306ee16ce096b238377b82770R137-R148
There's a test for this here:
https://github.com/apache/flink/pull/29050/changes#diff-662023392a0949caa3a0814536613caf4fb2a17c1e6f3d7217e829bee0d50390R142-R154
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
