yuxiqian commented on code in PR #4519:
URL: https://github.com/apache/flink-cdc/pull/4519#discussion_r3902598379
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/source/reader/external/FetchTask.java:
##########
@@ -66,6 +66,14 @@ interface Context {
boolean isDataChangeRecord(SourceRecord record);
+ /** Returns whether the given record is a schema change event. */
+ boolean isSchemaChangeEvent(SourceRecord record);
Review Comment:
I'm a little dubious about this, as the `isSchemaChangeEvent` check should
be deterministic, and providing a possibly wrong default implementation is
misleading.
Do we really need this method? Can we just check it in the
`shouldEmitSchemaChangeEvent` method? The invocation cost should be the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
