1996fanrui opened a new pull request, #29064:
URL: https://github.com/apache/flink/pull/29064
## What is the purpose of the change
On the normal recovery path, when a fan-in rescale merges several old input
channels into one new channel,
`DemultiplexingRecordDeserializer` aggregates the recovered non-record
elements across the merged channels:
it emits the min watermark (suppressed until every merged channel has one)
and ACTIVE if any channel is
active. With checkpointing during recovery enabled that aggregation moves to
the unspilling thread, but
`ChannelStateFilteringHandler` passed watermarks and statuses through
verbatim — so a high watermark from one
merged channel advanced the operator watermark prematurely and legitimate
in-flight lower-timestamp records
were dropped as late (silent data loss), and an IDLE from one merged channel
wrongly idled the whole channel.
This performs the same min-watermark / any-active aggregation on the
unspilling thread.
## Brief change log
- [FLINK-40517] Aggregate the min watermark (held while any merged old
channel is still uninitialized) and any-active watermark-status per new channel
in `ChannelStateFilteringHandler`; `NO_RESCALE` and fan-out stay verbatim.
## Verifying this change
This change added tests:
- `GateFilterHandlerTest` cases for fan-in min-watermark merge (with
hold-until-all) and any-active watermark-status; both fail on verbatim
pass-through.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
(recovery-time unspilling only)
- Anything that affects deployment or recovery: yes (unaligned-checkpoint
restore with in-flight channel state on rescale)
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
- [ ] Yes (please specify the tool below)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
