yuxiqian commented on code in PR #4475:
URL: https://github.com/apache/flink-cdc/pull/4475#discussion_r3910274389
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mongodb-cdc/src/test/java/org/apache/flink/cdc/connectors/mongodb/table/MongoDBRegexFilterITCase.java:
##########
@@ -49,6 +49,7 @@ class MongoDBRegexFilterITCase extends MongoDBSourceTestBase {
void setup(boolean parallelismSnapshot) {
TestValuesTableFactory.clearAllData();
+ tEnv.getConfig().set("table.exec.sink.require-on-conflict", "false");
Review Comment:
This is necessary due to changes in
https://github.com/apache/flink/pull/27426.
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-kafka/src/test/java/org/apache/flink/cdc/connectors/kafka/json/debezium/DebeziumJsonSerializationSchemaTest.java:
##########
@@ -229,8 +229,8 @@ public void testSerializeWithSchemaAllDataTypes() throws
Exception {
BinaryStringData.fromString("test2"),
BinaryStringData.fromString("test3"),
DateData.fromEpochDay(100),
- TimeData.fromNanoOfDay(200_000_000L),
- TimeData.fromNanoOfDay(300_000_000L),
+ TimeData.fromNanoOfDay(2_000_000_000L),
+ TimeData.fromNanoOfDay(3_000_000_000L),
Review Comment:
This is changed as Flink SQL `TIME` now supports preserving nanosecond
precision (https://github.com/apache/flink/pull/26954).
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-tidb-cdc/src/test/java/org/apache/flink/cdc/connectors/tidb/table/TiDBConnectorITCase.java:
##########
@@ -384,18 +386,24 @@ void testMetadataColumns() throws Exception {
waitForSinkSize("sink", 10);
List<String> expected =
- Arrays.asList(
- "+I(inventory,products,101,scooter,Small 2-wheel
scooter,3.1400000000)",
- "+I(inventory,products,102,car battery,12V car
battery,8.1000000000)",
- "+I(inventory,products,103,12-pack drill bits,12-pack
of drill bits with sizes ranging from #40 to #3,0.8000000000)",
- "+I(inventory,products,104,hammer,12oz carpenter's
hammer,0.7500000000)",
- "+I(inventory,products,105,hammer,14oz carpenter's
hammer,0.8750000000)",
- "+I(inventory,products,106,hammer,16oz carpenter's
hammer,1.0000000000)",
- "+I(inventory,products,107,rocks,box of assorted
rocks,5.3000000000)",
- "+I(inventory,products,108,jacket,water resistent
black wind breaker,0.1000000000)",
- "+I(inventory,products,109,spare tire,24 inch spare
tire,22.2000000000)",
- "+U(inventory,products,106,hammer,18oz carpenter
hammer,1.0000000000)",
- "-U(inventory,products,106,hammer,16oz carpenter's
hammer,1.0000000000)");
+ new ArrayList<>(
+ Arrays.asList(
+ "+I(inventory,products,101,scooter,Small
2-wheel scooter,3.1400000000)",
+ "+I(inventory,products,102,car battery,12V car
battery,8.1000000000)",
+ "+I(inventory,products,103,12-pack drill
bits,12-pack of drill bits with sizes ranging from #40 to #3,0.8000000000)",
+ "+I(inventory,products,104,hammer,12oz
carpenter's hammer,0.7500000000)",
+ "+I(inventory,products,105,hammer,14oz
carpenter's hammer,0.8750000000)",
+ "+I(inventory,products,106,hammer,16oz
carpenter's hammer,1.0000000000)",
+ "+I(inventory,products,107,rocks,box of
assorted rocks,5.3000000000)",
+ "+I(inventory,products,108,jacket,water
resistent black wind breaker,0.1000000000)",
+ "+I(inventory,products,109,spare tire,24 inch
spare tire,22.2000000000)"));
+ if ("flink2".equals(System.getProperty("flink.profile"))) {
+ expected.add("-D(inventory,products,106,hammer,16oz carpenter's
hammer,1.0000000000)");
Review Comment:
https://github.com/apache/flink/pull/27838
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
