spuru9 commented on code in PR #1201:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1201#discussion_r3912698841
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/StandaloneFlinkService.java:
##########
@@ -179,17 +180,17 @@ public boolean scale(FlinkResourceContext<?> ctx,
Configuration deployConfig) {
var name =
StandaloneKubernetesUtils.getTaskManagerDeploymentName(clusterId);
var deployment =
kubernetesClient.apps().deployments().inNamespace(namespace).withName(name);
-
- if (deployment == null || deployment.get() == null) {
+ var deploymentCR = deployment.get();
+ if (deploymentCR == null) {
Review Comment:
Minor nit: `Deployment` is a standard built-in Kubernetes resource
(`apps/v1`), rather than a "CR" (Custom Resource). Naming it `tmDeployment` or
`deploymentResource` would be slightly more accurate, though this is purely
stylistic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
