[
https://issues.apache.org/jira/browse/FLINK-40523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rui Fan resolved FLINK-40523.
-----------------------------
Fix Version/s: 2.4.0
Resolution: Fixed
Merged to master(2.4.0) via: 03e57af1f65fa0718a4e592abced9e8d7dc37a72
> NetworkActionsLogger.tracePersist unconditionally builds the buffer debug
> string
> --------------------------------------------------------------------------------
>
> Key: FLINK-40523
> URL: https://issues.apache.org/jira/browse/FLINK-40523
> Project: Flink
> Issue Type: Sub-task
> Components: Runtime / Checkpointing
> Reporter: Rui Fan
> Assignee: Rui Fan
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.4.0
>
>
> `tracePersist(Buffer)` evaluates `buffer.toDebugString(INCLUDE_HASH)` as a
> call argument, outside the `isTraceEnabled` guard, so every persisted
> in-flight buffer pays a full copy + hash + allocation even when TRACE is off
> [1]. Fix: guard the conversion, like the other `tracePersist`/`traceRecover`
> overloads already do [2].
> [1]
> [https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/io/network/logger/NetworkActionsLogger.java#L99-L102]
>
> [2]
> [https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/io/network/logger/NetworkActionsLogger.java#L104-L108]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
