Jackeyzhe commented on PR #29015: URL: https://github.com/apache/flink/pull/29015#issuecomment-5556591581
Thanks for the patch. The production path looks correct to me: when the option is enabled, FINISHED and CANCELED jobs skip only HistoryServer archiving and still proceed to job-result registration and global cleanup, while FAILED jobs remain eligible for archiving. Could we also add a positive test showing that a FAILED job is still archived when `jobmanager.archive.only-failed-jobs` is enabled? The current new test covers only the FINISHED negative path, so an implementation that accidentally suppresses archiving for every globally terminal state would still pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
