raminqaf commented on code in PR #29092:
URL: https://github.com/apache/flink/pull/29092#discussion_r3943663705


##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/casting/CastRulesTest.java:
##########
@@ -267,6 +333,16 @@ class CastRulesTest {
                                                     "d", 
ARRAY(STRING()).getLogicalType())))
                             .build());
 
+    // The variant a VARIANT row field round-trips to. A ROW cast serializes 
each VARIANT field via
+    // BinaryRowWriter.writeVariant, which stores the field's sliced value and 
the object metadata
+    // but
+    // drops the position, so the read-back variant equals neither the 
original field view (non-zero
+    // pos) nor a freshly built scalar (empty metadata). This rebuilds that 
exact form at pos 0.

Review Comment:
   Shortened to 2 line



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to