gaborgsomogyi commented on PR #28982: URL: https://github.com/apache/flink/pull/28982#issuecomment-5567575348
I'm fine with the bugfix, found some gaps: Test gap: add (or restore, adapted) a test for = against a DOUBLE key with a Long literal that isn't exactly representable as a double (e.g. key = `9007199254740993`), asserting it's now pushed down with the nearest-double value mirroring the existing `gt()` test (`literalNotRepresentableAsDoubleIsConvertedToTheNearestDouble`). Right now only the comparison case is covered; equality relies on an unverified assumption about Calcite pre-folding. Description: rephrase "There is no change to the supported predicates or their push-down behavior" since it's no longer accurate since the DOUBLE-key precision-loss case now pushes down where it previously didn't. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
