Martijn Visser created FLINK-40641:
--------------------------------------
Summary: Cover the Prometheus reporter exposition contract
Key: FLINK-40641
URL: https://issues.apache.org/jira/browse/FLINK-40641
Project: Flink
Issue Type: Technical Debt
Components: Runtime / Metrics
Reporter: Martijn Visser
Assignee: Martijn Visser
The Prometheus reporter tests assert fragments of the scrape body with
{{contains()}}, never assert the {{Content-Type}}, and never send an {{Accept}}
header. Nothing covers {{PushGateway.push()}} or {{delete()}}. That makes it
impossible to say what a client upgrade changes for users, which is the
question that has kept FLINK-29623 open since 2022.
Assert the data rather than the bytes: parse the body and compare the set of
families and samples, so the assertions survive a change of client. Cover the
{{Accept}} negotiation including the header a real Prometheus server sends, the
reserved names a summary occupies, and the pushgateway request path and body.
No production change and no new dependency.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
