gyfora commented on code in PR #1199:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1199#discussion_r4003732813
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/ApplicationReconciler.java:
##########
@@ -273,6 +285,24 @@ private static void
setRandomJobResultStorePath(Configuration effectiveConfig) {
}
}
+ private static void setRandomApplicationResultStorePath(Configuration
effectiveConfig) {
+ if (effectiveConfig.contains(HighAvailabilityOptions.HA_STORAGE_PATH))
{
Review Comment:
I think we have the exact same result leak already for the job result store
logic. Not setting this config means that we have an inconsistent behaviour
between different flink versions. We can consider how to avoid the resource
leak as the next step but for now I think it makes sense to follow the
currently established approach
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
