MartijnVisser opened a new pull request, #29178:
URL: https://github.com/apache/flink/pull/29178
## What is the purpose of the change
* Add tests that pin what the Prometheus reporter exposes today, so that
FLINK-29623 can show what bumping the client changes for users
The current tests don't check the `Content-Type`, don't send an `Accept`
header, and don't cover what the push gateway receives.
No production code is changed and no dependency is added.
## Brief change log
* Added `PrometheusExpositionContractTest` for the names, types, labels
and values a user scrapes
* Added `PrometheusReservedNameTest` for the names a summary occupies,
over every reserved suffix
* Added `PrometheusHttpSurfaceTest` for the paths served and the
`Content-Type` per `Accept` header
* Added `PrometheusPushGatewayWireTest` for the push and delete requests
## Verifying this change
This change added tests and can be verified as follows:
* `mvn verify -pl flink-metrics/flink-metrics-prometheus
-Dprometheus.version=0.16.0` replays these tests against the candidate client.
Five fail: two where a `_created` name collides with a summary and one of the
pair is dropped, two where the client answers OpenMetrics, and one where an
unmatched path stops serving metrics
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (please specify the tool below)
Generated-by: Claude Code (Claude Opus 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
