MartijnVisser commented on code in PR #29145:
URL: https://github.com/apache/flink/pull/29145#discussion_r4009257675
##########
flink-filesystems/flink-s3-fs-presto/pom.xml:
##########
@@ -182,6 +182,14 @@ under the License.
<artifactId>presto-memory-context</artifactId>
</exclusion>
+ <!-- Alluxio: only used by Presto's caching
filesystem, which the S3
+ file system does not use. The shaded
client is an outdated uber-jar
+ that unnecessarily bloats the bundle. -->
+ <exclusion>
+ <groupId>org.alluxio</groupId>
+
<artifactId>alluxio-shaded-client</artifactId>
Review Comment:
This is a no-op. `org.alluxio` is not in this module's tree on master and
the shaded jar has no `alluxio/` entries. Presto only pulls it via
`presto-cache`, which is already excluded here.
##########
flink-filesystems/flink-s3-fs-presto/src/main/resources/META-INF/NOTICE:
##########
@@ -39,7 +39,6 @@ This project bundles the following dependencies under the
Apache Software Licens
- io.airlift:slice:0.38
- io.airlift:units:1.3
- joda-time:joda-time:2.5
-- org.alluxio:alluxio-shaded-client:2.8.1
Review Comment:
`software.amazon.ion:ion-java:1.0.2` and `javax.xml.bind:jaxb-api:2.3.1` are
stale in the same way, want to remove those too? The checker only tolerates
them, so CI never complained.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
