HundalTaran commented on PR #28266: URL: https://github.com/apache/flink/pull/28266#issuecomment-5695508156
> Thanks for the PR. `TableEnvironment` is `@PublicEvolving`, so adding a method to it is a public API change and needs a FLIP first. See https://flink.apache.org/how-to-contribute/contribute-code/ and https://cwiki.apache.org/confluence/display/FLINK/Flink+Improvement+Proposals. > > Also note that the change doesn't work as is: `QueryOperationConverter` re-scans the table by identifier, so the options never reach the planner. A datagen table with `number-of-rows` = 3 still returns 3 rows via `from("T", Map.of("number-of-rows", "1"))`, while the SQL hint returns 1. Thanks for the review, Martijn — I will work on both points. I have started the discussion for the flip and in the meantime I will work on the bug. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
