MartijnVisser commented on PR #309: URL: https://github.com/apache/flink-connector-kafka/pull/309#issuecomment-5744083313
@vbhanuchander-lang #300 carries the same dedup and has been open since 7 September under FLINK-39712. I filed FLINK-40586 an hour later and assigned it to you without spotting the overlap. That is my mistake. The dedup can't land on its own. `handleNoMoreSplits` is reached from the proxy callback part way through `addReaderToClusterEnumerators`, so the first signal goes out before the other clusters have assigned. On `main` a later one corrects it; once the set makes it the only signal, the reader finishes holding one cluster's splits. Four of #300's five tests fail on this branch for exactly that. So I want #300 in first, with its deferral, and this PR reduced to the clear in `onHandleSubscribedStreamsFetch` that #300 doesn't have. Please rebase once it lands and drop the set, its initialiser and the reset in `addReader`. #300 also wires `signalNoMoreSplitsCallback` in `TestKafkaEnumContextProxyFactory`, so the test you couldn't write works on that base. I'll re-scope FLINK-40586 and it stays assigned to you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
