Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3149#discussion_r98805674
  
    --- Diff: 
flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/TableInputFormat.java
 ---
    @@ -41,7 +41,7 @@
     /**
      * {@link InputFormat} subclass that wraps the access for HTables.
      */
    -public abstract class TableInputFormat<T extends Tuple> extends 
RichInputFormat<T, TableInputSplit> {
    +public abstract class TableInputFormat<T> extends RichInputFormat<T, 
TableInputSplit> {
    --- End diff --
    
    I'd rather rename this class to `AbstractTableInputFormat<T>` and add a new 
class `TableInputFormat<T extends Tuple>` to keep the API stable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to