Jackeyzhe commented on PR #29169: URL: https://github.com/apache/flink/pull/29169#issuecomment-5748531731
Thanks for the focused fix. The queue cleanup and concurrent `LinkedBlockingQueue` removal look sound, and the exact-head ForSt test passes locally. One non-blocking test gap: the new ordering deliberately unregisters before `closeCachedStream()` so an exception from the cached stream cannot retain the wrapper, but the current test opens an entry in `REMOVED` state and only exercises the `CACHED_CLOSED` path. Could we add a case with a cached `FSDataInputStream` whose `close()` throws, then assert the wrapper is absent from `openedStreams` after the exception? I tried that characterization locally and it passes on this head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
