MartijnVisser commented on code in PR #29120:
URL: https://github.com/apache/flink/pull/29120#discussion_r4064912529
##########
flink-core/src/test/java/org/apache/flink/util/MdcLogbackCompatibilityTest.java:
##########
@@ -50,10 +50,9 @@ void tearDown() throws Exception {
}
/**
- * The {@link MDC#setContextMap(Map)} method in Logback 1.2 does not
accept nulls, unlike Log4j
- * and Logback 1.3.2. BasicMDCAdapter is used to replicate this behavior
for testing without
- * bundling Logback into flink-core. See
https://issues.apache.org/jira/browse/FLINK-36227 for
- * details.
+ * Restoring an absent (null) MDC context must not fail, regardless of the
backend in use.
Review Comment:
`BasicMDCAdapter.setContextMap(null)` is a no-op in SLF4J 2, so this passes
with the `MdcUtils` null guard removed, and fails on the base.
`Log4jMDCAdapter` still throws, so a null-rejecting adapter keeps the coverage.
##########
flink-dist/src/main/resources/META-INF/NOTICE:
##########
@@ -34,7 +34,7 @@ See bundled license files for details.
This project bundles the following dependencies under the MIT/X11 license.
See bundled license files for details.
-- org.slf4j:slf4j-api:1.7.36
+- org.slf4j:slf4j-api:2.0.19
Review Comment:
`META-INF/licenses/LICENSE.slf4j-api` still carries the 2004-2017 copyright
line, 2.0.19 ships 2004-2023.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
