MartijnVisser opened a new pull request, #246:
URL: https://github.com/apache/flink-connector-jdbc/pull/246
## What is the purpose of the change
- Pins the Table sink's changelog behavior with tests before
`JdbcDynamicTableSink` moves to Sink V2 (FLINK-37987).
## Brief change log
- `TableBufferReducedStatementExecutorTest`: reduce by key, upserts before
deletes, buffer kept for the retry
- `JdbcOutputFormatTest`: both upsert branches, append-only, NULL key,
unknown key field, object reuse, failed flush replayed
- `JdbcDynamicTableSinkITCase`: one buffer window with the upsert
materializer off, `sink.parallelism` above the input; disabled for Trino like
`testUpsert`
## Verifying this change
This change added tests and can be verified as follows:
- The new tests on Derby, MySQL and Postgres, on Flink 2.0.1 and 2.3.0
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (please specify the tool below)
Generated-by: Claude Code (Fable 5.1)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
