MartijnVisser commented on code in PR #188:
URL:
https://github.com/apache/flink-connector-jdbc/pull/188#discussion_r4070165065
##########
flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/JdbcExecutionOptions.java:
##########
@@ -102,8 +117,21 @@ public Builder withMaxRetries(int maxRetries) {
return this;
}
+ /**
+ * Enable or disable the dialect's bulk insert optimization. The
selected dialect must
+ * implement {@link
+ *
org.apache.flink.connector.jdbc.core.database.dialect.JdbcBulkInsertDialect};
when
+ * enabled with a dialect that does not, the sink fails fast at build
time.
+ *
+ * <p>Default is {@code false}.
+ */
+ public Builder withBulkInsertEnabled(boolean enabled) {
Review Comment:
`withBulkInsertEnabled` is only read by `JdbcOutputFormatBuilder`, so this
does nothing for the DataStream `JdbcSink`. Section 4.2 of the description says
otherwise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
