[ 
https://issues.apache.org/jira/browse/FLINK-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15848626#comment-15848626
 ] 

ASF GitHub Bot commented on FLINK-2168:
---------------------------------------

Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/3149
  
    Hi all,
    
    thanks for the feedback. Let's stick to the nested schema then.
    
    I think the best approach to support projections on nested fields is to 
implement a second interface (i.e., a trait without default implementation) 
called `NestedFieldsProjectableTableSource` as @tonycox suggested.
    Adding a method with default implementation to `ProjectableTableSource` 
would not work, because this would turn this class into a Java abstract class 
while it is an interface now.
    Using flat indicies is not a very nice solution either, IMO because it is 
not easy to parse.
    
    For now I'd suggest to keep the scope of the PR as it is right now. A bit 
more Java documentation on `HBaseTableSource` to explain how it is used would 
be great.
    We can implement the `NestedFieldsProjectableTableSource` and the changes 
to `HBaseTableSource` in a follow up issue.
    
    What do you think?


> Add HBaseTableSource
> --------------------
>
>                 Key: FLINK-2168
>                 URL: https://issues.apache.org/jira/browse/FLINK-2168
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>    Affects Versions: 0.9
>            Reporter: Fabian Hueske
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Minor
>
> Add a {{HBaseTableSource}} to read data from a HBase table. The 
> {{HBaseTableSource}} should implement the {{ProjectableTableSource}} 
> (FLINK-3848) and {{FilterableTableSource}} (FLINK-3849) interfaces.
> The implementation can be based on Flink's {{TableInputFormat}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to