anand-h-codes commented on PR #29204: URL: https://github.com/apache/flink/pull/29204#issuecomment-5810687276
@xuyangzhong I agree with you, plus as an optimisation I think we don't need to check the state for the `JoinKeyContainsUniqueKey` case. In this case, the maximum numOfAssociations possible is 1. We can take advantage of that and we can cap the numOfAssociations to 1. i.e setting it to 1 instead of incrementing it. As `JoinKeyContainsUniqueKey` is the most used case, it wouldn't cost extra state read. But the `HasUniqueKey` case would need extra I/O. I have these changes in the [PR-29264](https://github.com/apache/flink/pull/29264) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
