rmetzger commented on code in PR #1189: URL: https://github.com/apache/flink-kubernetes-operator/pull/1189#discussion_r4094595991
########## flink-autoscaler/src/test/java/org/apache/flink/autoscaler/KafkaPulsarPartitionMetricsITCase.java: ########## @@ -0,0 +1,367 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.autoscaler; + +import org.apache.flink.api.common.JobID; +import org.apache.flink.api.common.JobStatus; +import org.apache.flink.autoscaler.state.InMemoryAutoScalerStateStore; +import org.apache.flink.autoscaler.topology.JobTopology; +import org.apache.flink.client.program.rest.RestClusterClient; +import org.apache.flink.configuration.Configuration; +import org.apache.flink.metrics.groups.UnregisteredMetricsGroup; +import org.apache.flink.runtime.highavailability.nonha.standalone.StandaloneClientHAServices; +import org.apache.flink.runtime.rest.messages.job.JobDetailsInfo; + +import org.apache.kafka.clients.admin.Admin; +import org.apache.kafka.clients.admin.AdminClientConfig; +import org.apache.kafka.clients.admin.NewTopic; +import org.apache.kafka.clients.producer.KafkaProducer; +import org.apache.kafka.clients.producer.ProducerConfig; +import org.apache.kafka.clients.producer.ProducerRecord; +import org.apache.kafka.common.serialization.StringSerializer; +import org.apache.pulsar.client.admin.PulsarAdmin; +import org.apache.pulsar.client.api.PulsarClient; +import org.apache.pulsar.client.api.Schema; +import org.junit.jupiter.api.AfterAll; +import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.Timeout; +import org.testcontainers.kafka.KafkaContainer; +import org.testcontainers.pulsar.PulsarContainer; + +import java.io.File; +import java.io.IOException; +import java.nio.charset.StandardCharsets; +import java.nio.file.Files; +import java.nio.file.Path; +import java.time.Duration; +import java.util.ArrayList; +import java.util.List; +import java.util.Properties; +import java.util.concurrent.TimeUnit; + +import static org.apache.flink.autoscaler.MiniClusterJobDriver.JOB_ID_MARKER; +import static org.apache.flink.autoscaler.MiniClusterJobDriver.KAFKA_SOURCE_NAME; +import static org.apache.flink.autoscaler.MiniClusterJobDriver.PULSAR_SOURCE_NAME; +import static org.apache.flink.autoscaler.MiniClusterJobDriver.REST_ADDRESS_MARKER; +import static org.apache.flink.autoscaler.MiniClusterJobDriver.SEQUENCE_SOURCE_NAME; +import static org.assertj.core.api.Assertions.assertThat; +import static org.awaitility.Awaitility.await; + +/** + * Verifies that {@link ScalingMetricCollector#getJobTopology} derives the correct {@code + * numSourcePartitions} against real Kafka and Pulsar brokers: multi-topic summing, dotted and + * hyphenated topic names, source parallelism > 1, multiple source vertices in one job, and a + * non-Kafka/Pulsar source that must not report a partition count. + */ +class KafkaPulsarPartitionMetricsITCase { + + private static final String KAFKA_TOPIC_DOTTED = "orders.eu.v1"; + private static final int KAFKA_TOPIC_DOTTED_PARTITIONS = 3; + private static final String KAFKA_TOPIC_HYPHEN = "my-topic"; + private static final int KAFKA_TOPIC_HYPHEN_PARTITIONS = 2; + private static final String KAFKA_TOPIC_MULTI_SUBTASK = "high-parallel-topic"; + private static final int KAFKA_TOPIC_MULTI_SUBTASK_PARTITIONS = 6; + private static final int EXPECTED_KAFKA_PARTITIONS = + KAFKA_TOPIC_DOTTED_PARTITIONS + + KAFKA_TOPIC_HYPHEN_PARTITIONS + + KAFKA_TOPIC_MULTI_SUBTASK_PARTITIONS; + + private static final String PULSAR_TOPIC = "orders-v2"; + private static final int PULSAR_TOPIC_PARTITIONS = 4; + + private static KafkaContainer kafka; + private static PulsarContainer pulsar; + private static Process driverProcess; + private static Path driverResultFile; + private static String restAddress; + private static JobID jobId; + private static Path driverLogFile; + + @BeforeAll + static void setup() throws Exception { + kafka = new KafkaContainer("apache/kafka:3.8.0"); + kafka.start(); + createKafkaTopicsAndProduce(); + + pulsar = new PulsarContainer("apachepulsar/pulsar:3.2.3"); + pulsar.start(); + createPulsarTopicAndProduce(); + + driverResultFile = Files.createTempFile("autoscaler-it-driver-result", ".txt"); + Files.delete(driverResultFile); + driverLogFile = Files.createTempFile("autoscaler-it-driver", ".log"); + driverProcess = + startDriverProcess( + kafka.getBootstrapServers(), + pulsar.getPulsarBrokerUrl(), + pulsar.getHttpServiceUrl(), + driverResultFile, + driverLogFile); + awaitDriverReady(driverProcess, driverResultFile); + } + + @AfterAll + static void teardown() throws Exception { + if (driverProcess != null) { + driverProcess.destroy(); + if (!driverProcess.waitFor(10, TimeUnit.SECONDS)) { + driverProcess.destroyForcibly(); + } + } + if (driverResultFile != null) { + Files.deleteIfExists(driverResultFile); + } + if (driverLogFile != null) { + Files.deleteIfExists(driverLogFile); Review Comment: ideally when there's an error, print the entire log contents to the output? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
