MartijnVisser opened a new pull request, #29276:
URL: https://github.com/apache/flink/pull/29276
## What is the purpose of the change
Since FLINK-40704 the nightly snapshot jobs fail in spotless on JDK 11.
google-java-format 1.25.0 and later need Java 17, and only `java11-target`
selects 1.24.0, which the scripts in `tools/releasing` do not activate. This
picks 1.24.0 by the JDK that runs Maven instead.
## Brief change log
- New profile `spotless-java11`, activated on JDK `[11,17)`, sets
`aosp.version` to 1.24.0
- `java11-target` no longer sets `aosp.version`
## Verifying this change
On JDK 11 with the flags of both nightly jobs, `validate -pl
flink-annotations` fails on a6c87283904 with the same error as CI and passes
with this change. A full local `deploy_staging_jars.sh` run also passes (173
modules, 12 minutes).
JDK 17 and 21 with `-Pjava11-target` move from 1.24.0 to 1.28.0. No CI job
uses that combination, and `spotless:check` passes on the whole tree with
1.28.0.
The spotless check in CI runs on JDK 17 with 1.28.0, while the JDK 11
snapshot and release builds now use 1.24.0. Versions 1.25.0 to 1.28.0 only
change the formatting of text blocks and `when` guards, which Java 11 code
cannot contain. Both give identical output on the 11,058 Java files from before
spotless was introduced.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): yes
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (please specify the tool below)
Generated-by: Claude Code (Claude Opus 5.5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
