MartijnVisser commented on code in PR #24826:
URL: https://github.com/apache/flink/pull/24826#discussion_r4094676312
##########
flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/rest/SessionRelatedITCase.java:
##########
@@ -166,6 +166,7 @@ void testTouchSession() throws Exception {
long lastAccessTime = session.getLastAccessTime();
+ Thread.sleep(1); // ensure requests are not sent at the same time
Review Comment:
Could you rebase, replace the sleep with flink-runtime's
`CommonTestUtils.waitUntilCondition` until `System.currentTimeMillis() >
lastAccessTime`, and switch the assertion back to `isGreaterThan`? With those
changes it passed 2000 of 2000 runs locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
