vahmed-hamdy commented on code in PR #29290: URL: https://github.com/apache/flink/pull/29290#discussion_r4103201824
########## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/RetryingExecutionGraphCreation.java: ########## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.scheduler.adaptive; + +import org.apache.flink.api.common.JobStatus; +import org.apache.flink.runtime.executiongraph.ExecutionGraph; + +import org.slf4j.Logger; + +import javax.annotation.Nullable; + +import java.time.Duration; +import java.util.concurrent.ScheduledFuture; + +/** + * State entered when {@link CreatingExecutionGraph} fails to create the {@link ExecutionGraph} with + * a recoverable error. Unlike {@link Restarting}, there is no live ExecutionGraph to cancel here + * (the creation failed, and any previous graph is already terminal). This state simply waits for + * the configured backoff and then transitions back to {@link WaitingForResources} to re-attempt + * resource acquisition and ExecutionGraph creation. + */ +class RetryingExecutionGraphCreation extends StateWithoutExecutionGraph { + + private final Context context; + + private final Duration backoffTime; + + @Nullable private final ExecutionGraph previousExecutionGraph; + + @Nullable private ScheduledFuture<?> goToSubsequentStateFuture; + + RetryingExecutionGraphCreation( + Context context, + Logger logger, + @Nullable ExecutionGraph previousExecutionGraph, + Duration backoffTime) { + super(context, logger); + this.context = context; + this.previousExecutionGraph = previousExecutionGraph; + this.backoffTime = backoffTime; + + // State transitions are not allowed in the constructor, so schedule for later. Review Comment: redundant comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
