MartijnVisser commented on code in PR #29296:
URL: https://github.com/apache/flink/pull/29296#discussion_r4107304170
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/stream/StreamingJoinOperator.java:
##########
@@ -215,6 +217,8 @@ protected void processElement(
input.setRowKind(RowKind.INSERT); // erase RowKind for later state
updating
if (isAccumulateMsg) { // record is accumulate
+ final boolean isAdditionalMatch =
+ isAdditionalMatch(input, inputSideStateView, inputIsLeft);
Review Comment:
Mini-batch runs through this too. A suppressed `-U` decrements the count but
keeps the row in state, so the paired `+U` isn't counted. After `-U/+U` on one
of two matches, deleting the other emits a null-padded row. `isSuppress ||`
fixes that.
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/stream/StreamingJoinOperator.java:
##########
@@ -39,9 +39,11 @@ public class StreamingJoinOperator extends
AbstractStreamingJoinOperator {
private static final long serialVersionUID = -376944622236540545L;
- // whether left side is outer side, e.g. left is outer but right is not
when LEFT OUTER JOIN
+ // whether left side is outer side, e.g. left is outer but right is not
when
+ // LEFT OUTER JOIN
protected final boolean leftIsOuter;
- // whether right side is outer side, e.g. right is outer but left is not
when RIGHT OUTER JOIN
+ // whether right side is outer side, e.g. right is outer but left is not
when
+ // RIGHT OUTER JOIN
Review Comment:
Unrelated reformatting, please revert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
