MartijnVisser opened a new pull request, #29329:
URL: https://github.com/apache/flink/pull/29329
## What is the purpose of the change
The Avro Confluent Schema Registry e2e test has not run since 2.0, as it
needed the Kafka connector (FLINK-36268). This brings it back without the
connector: records go through files and the registry runs in Testcontainers.
## Brief change log
- Remove the shell test and the two Kafka helper scripts it was the last
user of
- Let the `upsert-files` test sink accept format options
- `ConfluentSchemaRegistryITCase` runs the reworked
`TestAvroConsumerConfluent` job and a SQL client job through the shaded
`flink-sql-avro-confluent-registry` jar
- `DockerImageVersions.KAFKA` and `SCHEMA_REGISTRY` were unused in Flink
and now point to `apache/kafka:4.2.0` and `cp-schema-registry:8.1.0`; flink-cdc
reads `KAFKA` with a cp-kafka-only container
## Verifying this change
- `UpsertTestDynamicTableSinkITCase#testFormatOptionsAreForwarded` fails
without the factory fix
- `ConfluentSchemaRegistryITCase` passed 10 runs in a row locally, about a
minute each, and fails on a changed magic byte, kafka-clients missing from the
shaded SQL jar, a wrong subject and an unreachable registry
Reading through the SQL format is not covered, as no source in the repo
keeps binary records intact. The Kafka side goes to flink-connector-kafka in
FLINK-40838.
This adds about a minute to each e2e group 4 run, plus the Kafka and
registry images in its Docker cache.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no, test scope only
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (please specify the tool below)
Generated-by: Claude Code (Claude Opus 5.5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
