Savonitar commented on code in PR #55: URL: https://github.com/apache/flink-connector-http/pull/55#discussion_r4136618291
########## .github/PULL_REQUEST_TEMPLATE.md: ########## @@ -0,0 +1,69 @@ +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +--> + +<!-- +Thank you for contributing to the Apache Flink HTTP connector. +Please follow the Flink contribution guide: +https://flink.apache.org/how-to-contribute/contribute-code/ + +Use a title in the form "[FLINK-XXXX][Connectors/HTTP] Description" +and link the corresponding Jira issue below. Documentation typo fixes do not +require a Jira issue. +--> + +## Purpose of the change + +<!-- Link the Jira issue and explain the problem this change addresses. --> Review Comment: Hi @davidradl . Thanks for the suggestion. I addressed it in a separate commit (didnt squash, to simplify the review). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
