MartijnVisser commented on code in PR #29333:
URL: https://github.com/apache/flink/pull/29333#discussion_r4263976445
##########
flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/service/application/ScriptExecutorITCase.java:
##########
@@ -151,7 +151,10 @@ void testParseStatementWithoutSemicolon() throws Exception
{
void testParseErrorPositionIsCorrect() throws Exception {
assertThat(runScript("error.q"))
.contains(
- "org.apache.flink.table.api.SqlParserException: SQL
parse failed. Encountered \")\" at line 26, column 1.");
+ "org.apache.flink.table.api.SqlParserException: SQL
parse failed. At line 26, column 1:\n"
Review Comment:
Done: Calcite line, then the echoed line, then the "Was expecting" list.
Errors without a position in the text get it appended to the reason.
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/delegation/PlannerContext.java:
##########
@@ -172,11 +173,17 @@ public FlinkRelBuilder createRelBuilder() {
public FlinkPlannerImpl createFlinkPlanner() {
return new FlinkPlannerImpl(
- createFrameworkConfig(), this::createCatalogReader,
typeFactory, cluster);
+ createFrameworkConfig(),
+ createCalciteParser(),
Review Comment:
No, `DefaultParserFactory` and a few tests call it. Not created twice
either: `FlinkPlannerImpl` already built its own parser, it now takes the same
one `ParserImpl` gets, so both see the sensitive keys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
