sangkyoonnam commented on PR #1219: URL: https://github.com/apache/flink-agents/pull/1219#issuecomment-6168954452
I went through 76d56d32 and it looks right to me. Every built-in call site, Java and Python, keeps the ID returned by `created` or `started` and passes it to the later reports, so `BuiltInExecutionMetrics` pairs each start with its terminal report by that ID. It also fixes a small mismatch: a resolved sub-agent call with non-object arguments used to be created as `subagent` and failed as `tool`, and both reports now use the same ID, type and name. Focused runs at cda75450 pass: 248 Java tests under JDK 21 and 179 Python tests. One Javadoc suggestion. The Java `ExecutionReporter` says metadata describes the call, while the Python docstring says it describes the observation. Could Java match Python and add that each report carries only its own metadata, with no merge across reports for the same ID? The #1160 exporter would then know what each record holds. If you'd rather keep this PR's scope, I can send it as a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
