dalelane commented on PR #29379: URL: https://github.com/apache/flink/pull/29379#issuecomment-6180224296
> Dumping some AI feedback, which I have briefly skimmed, for you to evaluate > > _many ideas <snip>_ There was a lot there! It was useful though, thanks. --- **1. SIGTERM can permanently fail the job** fixed in c905315e8ca --- **6. logging exit codes** added in 631bd2c18d4 --- **7. RPC thread pool and ask timeout** added RPC pool in 81893d177d8 and the ask timeout in ca48181b3a7 --- **10. JMX and FileSystem.attachMetrics** JMX - added in 502d1572b40 FileSystem.attachMetrics - I don't think any change is needed. I tried it out against a local Seaweed and I got S3 metrics. Attaching the process group didn't seem to make any difference. --- **11. Fixed working directory** Yes, MiniCluster uses a working dir with a random suffix and deletes it on close, so local recovery can't work after a restart. I think it'll need flink-runtime changes to fix this, but that feels like a broader change than I should include in a pull request for a launcher. (And I don't need it for FLIP-611) If you think this is important, I could raise a separate Jira ticket for this? --- **Screenshot: changelog storage plugins** Added in 7f7418aa816 --- **Screenshot: failure enrichers** Added in 6cb4b5d90ec --- **Screenshot: JobManager fatal errors** fixed as part of the changes in 238852ed07d --- **Screenshot: LEGACY claim-mode warning** I don't see how the warning in StandaloneApplicationClusterEntryPoint could fire. The parser for the entrypoint used by the container doesn't register claimMode/restoreMode. I think it's meant to be set through config, but the check doesn't look at config? I left it for this pull request - happy to create a separate Jira ticket and investigate properly for how to fix for both entrypoints if you think it's important. --- **Screenshot: exit codes, program close(), final log line** Added in 631bd2c18d4 --- I think that's everything! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
