sangkyoonnam commented on PR #688: URL: https://github.com/apache/flink-agents/pull/688#issuecomment-6246896933
Hi @twosom, thanks for starting the Python event listener work. Are you planning to continue this PR? It was last updated on June 3 and now has merge conflicts with main. If you're open to it, I'd like to build on your work. I'd follow @wenjin272's suggestions: a single `PythonEventListenerWrapper` that uses pemja at runtime to create the Python `EventListener` and call `on_event`. Listeners would use plain fully qualified names like `my_module.MyListener`. I'd leave out `local_runner` support and add end-to-end tests that submit jobs in `e2e_tests_resource_cross_language`. I'd also let Java and Python listeners run in the same operator, per @weiqingy's first review point. I'll credit your work and keep you as a co-author on commits that reuse your code. If I haven't heard back in a week, I'll ask @wenjin272 on #687 about assigning it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
