dianfu commented on PR #28987:
URL: https://github.com/apache/flink/pull/28987#issuecomment-6259345435
@beetle0915 Thanks for addressing the previous review comments. After
another pass, I feel that the implementation has makes the already complex code
significantly harder to understand and maintain.
The original limitation also has a straightforward workaround by
materializing the computed grouping expression before aggregation. For example:
Expression key = $("a").isGreater(10);
Table withKey = table.addColumns(key.as("group_key"));
withKey.groupBy($("group_key"))
.select($("group_key"), $("b").count());
Since the issue occurs during query validation, does not cause incorrect
runtime results, and can be avoided with the pre-projection above, I am
inclined to keep the current behavior and defer this fix for now. We can
revisit it later if there is a simpler design that does not add this level of
complexity to the aggregation paths.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
