sangkyoonnam commented on code in PR #1262:
URL: https://github.com/apache/flink-agents/pull/1262#discussion_r4311619077


##########
docs/content/docs/operations/monitoring.md:
##########
@@ -22,107 +22,124 @@ specific language governing permissions and limitations
 under the License.
 -->
 
-## Metric
 
-### Built-in Metrics
+## Overview
 
-We offer data monitoring for built-in metrics, including input runs, events, 
actions, execution health, and token usage.
+A running agent produces three kinds of observability data, and each answers a 
different question.
 
-#### Event and Action Metrics
+- **Metrics** show how much and how fast: Event and Action throughput, 
input-run outcomes and latency, LLM, Tool and sub-agent calls, and token usage. 
They go through [Flink's metric 
system](https://nightlies.apache.org/flink/flink-docs-release-1.20/docs/ops/metrics/),
 so they reach the same reporters and dashboards as the rest of the job.
+- **Logs** carry what your Action code and the framework write through Flink's 
logging framework, such as warnings and stack traces.
+- **The [Trace Log](#trace-log)** records Events, Action executions and the 
calls made within Actions as structured JSON, so you can follow what one input 
did. By default it records only Events; configure `trace-log.targets` to 
include Actions and component calls.

Review Comment:
   Updated in bb48488e: Recording Targets now introduces `EVENT_ONLY` (Events 
only, the default) and `ALL` (all entity types the framework observes) before 
the example. Matching rules remain in the configuration reference.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to