ShawnGarello commented on issue #1255: URL: https://github.com/apache/flink-agents/issues/1255#issuecomment-6272687303
Hi @weiqingy, I'd like to work on this if you haven't started on it yourself. Failing at setup sounds good to me. One small correction to the table: Java Bedrock doesn't send a blank model as is. `BedrockChatModelConnection.resolveModel` treats it as unset and falls back to the connection's `model` argument. So with this change a blank model on Bedrock would start failing too, the same as OpenAI, Anthropic and Gemini. That seems consistent with the rule, but I wanted to flag it. Plan: put the check in `BaseChatModelSetup` in Java and Python, remove the per-provider blank handling, and add tests for `""` and `" "` on each setup. An omitted model keeps today's behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
