uicosp commented on code in PR #3776:
URL: https://github.com/apache/flink-cdc/pull/3776#discussion_r4323984824
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/test/java/org/apache/flink/cdc/connectors/mysql/source/MySqlSourceITCase.java:
##########
@@ -496,6 +496,191 @@ void testSnapshotSplitReadingFailCrossCheckpoints(String
tableName, String chunk
jobClient.cancel().get();
}
+ @ParameterizedTest
+ @MethodSource("parameters")
+ @SuppressWarnings({"rawtypes", "unchecked"})
+ void testSnapshotFilters(String tableName, String chunkColumnName) throws
Exception {
Review Comment:
Added testSnapshotFiltersWithDMLPreHighWatermark, using SnapshotPhaseHooks
to update rows before the high watermark so that one enters the filter
condition and another leaves it.
The test covers snapshot backfill both enabled and skipped, verifying
normalized snapshot rows in the former case and the original snapshot rows
followed by unfiltered binlog updates in the latter. It passes on Flink 1.20
and 2.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
