eemario opened a new pull request, #1297:
URL: https://github.com/apache/flink-agents/pull/1297
Generated-by: Qoder
<!--
* Thank you very much for contributing to Flink Agents.
* Please add the relevant components in the PR title. E.g., [api],
[runtime], [java], [python], [hotfix], etc.
-->
<!-- Please link the PR to the relevant issue(s). Hotfix doesn't need this.
-->
Linked issue: #xxx
### Purpose of change
<!-- What is the purpose of this change? -->
Found during the #1283 documentation walkthrough: the shared-resources
example on the YAML API page declares `thinking:` and omits the required
`model`, so copying it fails at runtime with `TypeError:
OllamaChatModelSetup.__init__() missing 1 required positional argument:
'model'`, followed by `ValidationError: thinking — Extra inputs are not
permitted` once a model is added.
Both loaders only accept `think` (Python `OllamaChatModelSetup.think`,
default `True`; Java `descriptor.getArgument("think", true)`), and `model` is
required on both sides.
This changes `thinking` to `think` in both setups and adds `model: qwen3:8b`
(the model name already used by other examples on this page).
### Tests
<!-- How is this change verified? -->
- Extracted the example verbatim from the updated page and ran it through
`build_agents` (`PYTHONPATH=python python/.venv/bin/python`): PASSED;
materializing `OllamaChatModelSetup` from the descriptor arguments succeeds
with `model=qwen3:8b, think=False`.
### API
<!-- Does this change touches any public APIs? -->
No public API changes.
### Documentation
<!-- Do not remove this section. Check the proper box only. -->
- [ ] `doc-needed` <!-- Your PR changes impact docs -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [x] `doc-included` <!-- Your PR already contains the necessary
documentation updates -->
### Was this patch authored or co-authored using generative AI tooling?
<!-- Do not remove this section. Check the proper box only. -->
- [x] Yes
- [ ] No
Generated-by: Qoder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
