riyarawat-amazon commented on code in PR #258:
URL:
https://github.com/apache/flink-connector-aws/pull/258#discussion_r4326938372
##########
flink-connector-aws/flink-connector-aws-kinesis-firehose/src/test/java/org/apache/flink/connector/firehose/sink/KinesisFirehoseSinkWriterTest.java:
##########
@@ -50,7 +50,7 @@ public class KinesisFirehoseSinkWriterTest {
@BeforeEach
void setup() throws IOException {
TestSinkInitContext sinkInitContext = new TestSinkInitContext();
- Properties sinkProperties =
AWSServicesTestUtils.createConfig("https://fake_aws_endpoint";);
+ Properties sinkProperties =
AWSServicesTestUtils.createConfig("https://fake-aws-endpoint";);
Review Comment:
It is needed: with 2.56.0, building the writer's client fails on
https://fake_aws_endpoint (URISyntaxException ... at index 6, since an
underscore isn't valid in a host). These tests failed on CI before the change
and pass with 2.40.3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
