kotwal-itpro commented on PR #29397: URL: https://github.com/apache/flink/pull/29397#issuecomment-6300854348
@snuyanzin, could you take a look at this one when you have time? You worked on `AsyncWaitOperator` recently (FLINK-40456), and this fixes another way it loses data: an IDLE watermark status overtakes a queued watermark, so downstream drops that watermark and event time can stop advancing. The second commit fixes the same pattern in `RowTimeMiniBatchAssignerOperator`. I also have three smaller PRs open since Oct 6, all still merging cleanly, in case you or someone else has time for them: - #29394 FLINK-40922 (planner): `SELECT DISTINCT` over a `GROUP BY ROLLUP` returns duplicate rows when a group key is NULL. - #29395 FLINK-40919 (planner): `AVG` on an INT column overflows when it is rewritten to `SUM / COUNT`. This one is a draft because the fix has a planning trade-off I'd like a maintainer's view on. - #29396 FLINK-40836 (checkpointing): restoring with `execution.state-recovery.without-channel-state.checkpoint-id` drops the coordinator state, so FLIP-27 sources re-read data they already emitted. Happy to rebase or split anything if that helps. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
