dalelane opened a new pull request, #29537:
URL: https://github.com/apache/flink/pull/29537

   ## What is the purpose of the change
   
   MiniClusterJobEntryPointITCase was picking an available port number, and 
giving that to the MiniCluster to bind to. This introduced a race condition. In 
the window between identifying an available port, and starting a MiniCluster to 
bind to it, something else could grab the port, resulting in a test failure 
when the MiniCluster failed to start because the port it was trying to use was 
not free.
   
   ## Brief change log
   
   I've changed the minicluster config to use bind port 0 so it chooses a free 
port by itself. This does add some complexity to the test, because it means I 
have to go and discover what port it used after it's started to be able to 
submit queries.
   
   ## Verifying this change
   
   This is a fix to an ITCase test. Verified by running it repeatedly in a 
constrained VM to simulate a constrained CI worker.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [ ] Yes (please specify the tool below)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to