spuru9 opened a new pull request, #29539:
URL: https://github.com/apache/flink/pull/29539

   ## What is the purpose of the change
   
   `OverAggregateRestoreTest#generateTestSetupFiles` could not regenerate the 
files of 
`over-aggregate-bounded-non-partitioned-rows-with-out-of-order-records`: the 
sink waited for 18 rows, only 16 were produced, and the run failed after 5 
minutes. The program had been given the expected rows of the partitioned 
program. Without `PARTITION BY` the window spans all keys and late rows are 
dropped globally, so the expectations were wrong both before and after restore.
   
   ## Brief change log
   
     - `OverAggregateTestPrograms`: give the non-partitioned out-of-order 
program its own before-restore rows and use `AFTER_RESTORE_DATA` after restore
     - Regenerate the plan and savepoint of that program under 
`stream-exec-over-aggregate_1`
     - `RestoreTestBase`: cancel the job when waiting for the savepoint fails 
during generation, so later programs in the same JVM don't time out too
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as 
`OverAggregateRestoreTest`. Generation of the program now succeeds and all 
restore programs pass.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes (please specify the tool below)
   
   Generated-by: Claude Code (Sonnet 5.5)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to