[
https://issues.apache.org/jira/browse/FLINK-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15854040#comment-15854040
]
ASF GitHub Bot commented on FLINK-5714:
---------------------------------------
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/3273
[FLINK-5714] [table] Use a builder pattern for creating CsvTableSource
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
Add a builder to create CsvTableSource. And I have also updated the
documentation.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wuchong/flink
CsvTableSource-builder-FLINK-5714
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3273.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3273
----
commit 10ffca16901f748c3e2c3818f76cebbc9fcc3153
Author: Jark Wu <[email protected]>
Date: 2017-02-06T13:57:04Z
[FLINK-5714] [table] Use a builder pattern for creating CsvTableSource
----
> Use a builder pattern for creating CsvTableSource
> -------------------------------------------------
>
> Key: FLINK-5714
> URL: https://issues.apache.org/jira/browse/FLINK-5714
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: Jark Wu
>
> Right now, the constructor of the CsvTableSource can have up to 9 parameters.
> In Scala this might not be a problem because of default values, but Java
> doesn't have this functionality.
> I propose to have a builder pattern here:
> {code}
> CsvTableSource
> .builder()
> .field("myfield", Types.STRING)
> .field("myfield2", Types.INT)
> .quoteCharacter(';')
> .build()
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
