Jackeyzhe commented on PR #29488: URL: https://github.com/apache/flink/pull/29488#issuecomment-6310770799
I agree with the optional `ArrayList` suggestion above. With all appends inside `compute()` and the list not exposed elsewhere, a removed list has no concurrent writers; subsequent registrations use a new list. `ArrayList` should therefore suffice and avoid copying on each registration. This is non-blocking, and release callbacks should remain outside `compute()`. Other than this optional suggestion, I have no further comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
