MartijnVisser opened a new pull request, #29562:
URL: https://github.com/apache/flink/pull/29562
## What is the purpose of the change
`RpcEndpoint.MainThreadExecutor#schedule` runs the task as a `FutureTask`,
which stores what the task throws, so the RPC actor never logs the failure and
a fatal error does not exit the process, unlike for `execute()`. Details in
FLINK-41077.
## Brief change log
- Rethrow a scheduled task's failure in the main thread after it ran,
unless the task was cancelled; the returned future still carries it.
## Verifying this change
This change added tests and can be verified as follows:
- Three new tests in `RpcEndpointTest`: a `RuntimeException` and an
`Error` from a runnable and a checked exception from a callable must each reach
the gateway and fail the returned future. All three fail on the unmodified tree
and pass with the change.
- `RpcEndpointTest` 19 of 19, the test classes of the in-tree callers and
`ResourceManagerTest` 168 of 168, flink-rpc-core 8 of 8 and flink-rpc-akka 120
of 120, none skipped.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (please specify the tool below)
Generated-by: Claude Code (Claude Fable 5.1)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
