Efrat19 commented on code in PR #333:
URL:
https://github.com/apache/flink-connector-kafka/pull/333#discussion_r4351254056
##########
flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/reader/KafkaPartitionSplitReader.java:
##########
@@ -64,6 +66,12 @@
public class KafkaPartitionSplitReader
implements SplitReader<ConsumerRecord<byte[], byte[]>,
KafkaPartitionSplit> {
private static final Logger LOG =
LoggerFactory.getLogger(KafkaPartitionSplitReader.class);
+ // The commit delays closing the consumer. The reader waits for its
fetcher to close for at most
+ // source.reader.close.timeout, 30 seconds by default.
+ private static final Duration COMMIT_ON_CLOSE_TIMEOUT =
Duration.ofSeconds(10);
Review Comment:
Doesn't this mean a mandatory 10 seconds delay for all jobs?
Should we make it configurable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
